Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ERC: Request Method Types #315

Merged
merged 7 commits into from
Jun 11, 2024
Merged

Add ERC: Request Method Types #315

merged 7 commits into from
Jun 11, 2024

Conversation

HelloRickey
Copy link
Contributor

@HelloRickey HelloRickey commented Mar 13, 2024 •
edited
Loading

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Mar 13, 2024 •
edited
Loading

✅ All reviewers have approved.

@eip-review-bot eip-review-bot changed the title add Request Method Types Add ERC: Request Method Types Mar 13, 2024
@github-actions github-actions bot added the w-ci label Mar 13, 2024
abcoathup
abcoathup reviewed Mar 13, 2024
View reviewed changes
ERCS/erc-xxxx.md Outdated Show resolved Hide resolved
abcoathup
abcoathup reviewed Mar 13, 2024
View reviewed changes
ERCS/erc-xxxx.md Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the w-ci label Mar 14, 2024
@github-actions GitHub Actions
Copy link

The commit c52ba2d (as a parent of 0becde5) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci label Mar 14, 2024
@github-actions github-actions bot removed the w-ci label Mar 14, 2024
@HelloRickey HelloRickey mentioned this pull request Apr 1, 2024
Closed
18 tasks
@poojaranjan poojaranjan mentioned this pull request Apr 3, 2024
Closed
27 tasks
@poojaranjan poojaranjan mentioned this pull request Apr 16, 2024
Closed
19 tasks
@poojaranjan poojaranjan mentioned this pull request May 28, 2024
Closed
13 tasks
SamWilsn
SamWilsn requested changes May 29, 2024
View reviewed changes
ERCS/erc-7654.md Outdated Show resolved Hide resolved
ERCS/erc-7654.md Outdated Show resolved Hide resolved
assets/erc-7654/RequestMethodTypes.sol Outdated Show resolved Hide resolved
SamWilsn
SamWilsn reviewed Jun 10, 2024
View reviewed changes
ERCS/erc-7654.md Outdated Show resolved Hide resolved
ERCS/erc-7654.md Outdated Show resolved Hide resolved
ERCS/erc-7654.md Outdated Show resolved Hide resolved
ERCS/erc-7654.md Outdated Show resolved Hide resolved
ERCS/erc-7654.md Outdated Show resolved Hide resolved
ERCS/erc-7654.md Outdated Show resolved Hide resolved
@HelloRickey
Copy link
Contributor Author

Hey @SamWilsn Thanks again for your patience, please check again.

@eip-review-bot eip-review-bot enabled auto-merge (squash) June 11, 2024 14:28
eip-review-bot
eip-review-bot approved these changes Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eip-review-bot eip-review-bot merged commit ccaf79a into ethereum:master Jun 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abcoathup abcoathup abcoathup left review comments

@eip-review-bot eip-review-bot eip-review-bot approved these changes

@SamWilsn SamWilsn SamWilsn approved these changes

Assignees
No one assigned
Labels
c-new e-consensus e-review s-draft t-erc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HelloRickey @eip-review-bot @abcoathup @SamWilsn